[Scons-users] Possible bug with Value objects

[Dirk Bächle]

Hi Tom,

On 27.02.2015 17:48, Tom Tanner (BLOOMBERG/ LONDON) wrote:
> I've been trying to get my head round this, but it appears that the code to explain why a build has happened has problems with Value
> objects.
>

after some debugging of your example, I share your concerns. There are two basic problems, appearing for strange reasons that I 
still didn't fully understand:

1.) The default "__eq__" for Values doesn't work, so "x in l" fails...even if x is a member of the seq l, but of type Value!
2.) In the list of children (old_bkids/new_bkids, in Node.explain()), instances of the NodeInfo class may exist when Value nodes are 
involved.

Attached you can find a preliminary patch that seems to fix the problem. Do you think this is the right way to go, meaning: does 
this look reasonable to you?

Please open a ticket for this issue in the Tigris bug tracker, thanks a lot in advance.

Best regards,

Dirk

-------------- next part --------------
A non-text attachment was scrubbed...
Name: sig_value.patch
Type: text/x-patch
Size: 2905 bytes
Desc: not available
URL: <https://pairlist4.pair.net/pipermail/scons-users/attachments/20150228/3e2b09d6/attachment.bin>