[Scons-users] qt4 tool and scons 3.0

[Pierre-Luc Boily]

Thx, get_text_contents() resolved the problem.  Moc files are properly
generated now.

As for the fix that you were wondering if it might affect my build, I
decided to remove the fix and see.  Everything builds fine and is generated
where it needs to.

Otherwise, I was wondering why going from scons 2 to 3 broke the moc
feature?  I am not sure to understand...

thx a lot for your help, really appreciated!



On Tue, Oct 3, 2017 at 2:36 PM, Bill Deegan <bill at baddogconsulting.com>
wrote:

> Would this bit at the end which is commented out affect your build?
>
> -#Last edited : Bilal Itani - Fix to variant dir issue with qrc generated
> in source tree rather than being generated in build tree
> -#according to https://bitbucket.org/dirkbaechle/scons_qt4/issues/
> 10/qt4-generates-qrc_cc-files-in-the-wrong
>  def __qrc_path(head, prefix, tail, suffix):
> -    if head:
> -        if tail:
> -            return os.path.join(head, "%s%s%s" % (prefix, tail, suffix))
> -        else:
> -            return "%s%s%s" % (prefix, head, suffix)
> -    else:
> -        return "%s%s%s" % (prefix, tail, suffix)
> +   if head:
> +       if tail:
> +           return "%s%s%s" % (prefix, tail, suffix)#os.path.join(head,
> "%s%s%s" % (prefix, tail, suffix))
> +   #   else:
> +   #       return "%s%s%s" % (prefix, head, suffix)
> +    #else:
> +    #    return "%s%s%s" % (prefix, tail, suffix)
>
>
> On Tue, Oct 3, 2017 at 11:34 AM, Bill Deegan <bill at baddogconsulting.com>
> wrote:
>
>> I think if you change .get_contents() to .get_text_contents() in the
>> __init__.py (it occurs several places), it may work.
>>
>> get_contents() returns bytes, get_text_contents() returns strings
>>
>> On Tue, Oct 3, 2017 at 10:23 AM, Bill Deegan <bill at baddogconsulting.com>
>> wrote:
>>
>>> Can you pastebin the diffs for each (before and after you ran 2to3)?
>>>
>>> On Tue, Oct 3, 2017 at 8:55 AM, Pierre-Luc Boily <
>>> pierreluc.boily at gmail.com> wrote:
>>>
>>>> Only 3 files have been modified by 2to3 :
>>>>
>>>> Changes look minor for me, maybe I am wrong:
>>>>
>>>> __init__.py : https://pastebin.com/4LRdbtaS
>>>> sconstest-copied-env.py : https://pastebin.com/LFCG6QTj
>>>> create_scons_tests.py : https://pastebin.com/Uu0S9ccB
>>>>
>>>>
>>>>
>>>> --
>>>> Sent from: http://scons.1086193.n5.nabble.com/Users-f16930.html
>>>> _______________________________________________
>>>> Scons-users mailing list
>>>> Scons-users at scons.org
>>>> https://pairlist4.pair.net/mailman/listinfo/scons-users
>>>>
>>>
>>>
>>
>
> _______________________________________________
> Scons-users mailing list
> Scons-users at scons.org
> https://pairlist4.pair.net/mailman/listinfo/scons-users
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pairlist4.pair.net/pipermail/scons-users/attachments/20171003/374621ac/attachment-0001.html>