[Scons-users] more Java scons3 issues...

[Daniel Moody]

Hey mats,

I think you might be right, actually the last part was to catch the nodes
that passed through python isfile or isdir checks previously, so now it may
not be needed.

There are cases where it gets passed the two trys added in the PR which I
can tell from the swig tests which hit the ".i" extension check, but I am
going to investigate the ordering of checks in that PR because it doesn't
seem like it should be able to get passed the two tries.

Best regards



On Dec 29, 2017 12:53 PM, "Mats Wichmann" <mats at wichmann.us> wrote:

> On 12/29/2017 12:47 AM, Daniel Moody wrote:
> > Can you check out the changes from this pull request and see if it fixes
> > your issue?
> >
> > https://github.com/SCons/scons/pull/35
>
> I will try this presently.  I was exploring something down this path
> earlier with the same thinking.  My experiments indicated that the
> conversion to File fails only if the string refers to an existing
> directory (i.e. you still get a node even if the string does not refer
> to an existing file), so while it looks likely to work for our case of
> having a manifest file plus already-generated classfiles, it would
> prevent the code from hitting the later part of the loop - lines 206 and
> later in your patched version.  I don't have proof of that conjecture at
> this point, and will update here when I get a chance to test.
>
> >
> > On Dec 29, 2017 1:56 AM, "Daniel Moody" <dmoody256 at gmail.com> wrote:
> >
> >> Hey Mats,
> >>
> >> I am looking into this issue, where does the MANIFEST.MF file exist at
> the
> >> start of the build relative to the Scons file you mentioned above?
> >>
> >> What is your VariantDir call look like?
> >>
> >> Best regards
> >>
> >> On Sat, Dec 16, 2017 at 6:13 PM, Mats Wichmann <mats at wichmann.us>
> wrote:
> >>
> >>> On 12/16/2017 03:45 PM, Bill Deegan wrote:
> >>>> Did you try the current head of the master branch?
> >>>
> >>> yes. I thought that was implied in part of my reply:
> >>>
> >>>>>  The post 3.0.1 jar.py
> >>>>> changes help other problems I have, but not this one.
> >>> _______________________________________________
> >>> Scons-users mailing list
> >>> Scons-users at scons.org
> >>> https://pairlist4.pair.net/mailman/listinfo/scons-users
> >>>
> >>
> >>
> >
> >
> >
> > _______________________________________________
> > Scons-users mailing list
> > Scons-users at scons.org
> > https://pairlist4.pair.net/mailman/listinfo/scons-users
> >
>
> _______________________________________________
> Scons-users mailing list
> Scons-users at scons.org
> https://pairlist4.pair.net/mailman/listinfo/scons-users
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pairlist4.pair.net/pipermail/scons-users/attachments/20171229/dfa08432/attachment-0001.html>