[Scons-users] adding text to compile line

[Bill Deegan]

Dagg,

Understood.
The idea is you try this and let us know if it works for you, then we can
see if there's any downside in making that change in SCons and getting it
into the next release.

-Bill

On Fri, Feb 2, 2024 at 12:25 AM daggs via Scons-users <scons-users at scons.org>
wrote:

> Greetings Bill,
>
> I'll try it, just for the heck of it but it isn't a valid solution as I
> cannot ask multiple devs to make that change in their scons.
> the question is, can I remove them using the std python code?
> one of the main features we use is take the compile line and run it
> manually so we don't need to run the entire build just to test one line.
> these "addons" will wreck havoc in bash
>
> Dagg
>
> *Sent:* Friday, February 02, 2024 at 5:33 AM
> *From:* "Bill Deegan" <bill at baddogconsulting.com>
> *To:* "SCons users mailing list" <scons-users at scons.org>
> *Subject:* Re: [Scons-users] adding text to compile line
> Dagg,
>
> Interesting the CommandAction function to print *COMSTR calls subst with
> SUBST_RAW.
>
> If you're feeling adventurous, try changing these lines (around line 1039
> in SCons/Action.py
> from:
>             if executor:
>                 c = env.subst(self.cmdstr, SUBST_RAW, executor=executor,
> overrides=overrides)
>             else:
>                 c = env.subst(self.cmdstr, SUBST_RAW, target, source,
> overrides=overrides)
> To
>             if executor:
>                 c = env.subst(self.cmdstr, SUBST_CMD, executor=executor,
> overrides=overrides)
>             else:
>                 c = env.subst(self.cmdstr, SUBST_CMD, target, source,
> overrides=overrides)
>
> No need to do the replace() stuff in your env['LINKCOMSTR'] for the above.
>
> I think this should do what we all expected in the first place..
> (I can't think of any reason to leave the $( $)'s in the comstr  output..
> well I could probably think of some corner cases, but most people wouldn't
> want to see those I'd think.
> -Bill
>
> On Thu, Feb 1, 2024 at 5:11 PM Mats Wichmann <mats at wichmann.us> wrote:
>
>> On 2/1/24 16:05, daggs via Scons-users wrote:
>> > I'm not changing env['LINKCOM'], just env['LINKCOMSTR']
>> > Dagg
>>
>> Well, the way printing of the "default" is handled is a little
>> convoluted, we'll try to get a look at what would make sense to just
>> slightly modify the output (well, I'll try to take a look, can't speak
>> for others).
>>
>>
>> _______________________________________________
>> Scons-users mailing list
>> Scons-users at scons.org
>> https://pairlist4.pair.net/mailman/listinfo/scons-users
>
> _______________________________________________ Scons-users mailing list
> Scons-users at scons.org
> https://pairlist4.pair.net/mailman/listinfo/scons-users
> _______________________________________________
> Scons-users mailing list
> Scons-users at scons.org
> https://pairlist4.pair.net/mailman/listinfo/scons-users
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pairlist4.pair.net/pipermail/scons-users/attachments/20240202/4d0b0dd2/attachment.htm>