[Scons-users] SCons 4.5.0 Released

[Olivier, Jeffrey V]

unfortunately, it's hard to narrow down what the problem is.   My colleague added the following patch and in looking at the build output, NO_SUCH_ARG was used in denv even though it was only added to new_env.   In trying to reproduce this with a simpler example, I have so far been unable to do so.  For now, we will just pin to 4.4.

diff --git a/src/bio/SConscript b/src/bio/SConscript
index 2f8c86f4e..b09d86926 100644
--- a/src/bio/SConscript
+++ b/src/bio/SConscript
@@ -34,6 +34,9 @@ def scons():
     # Other libs
     libs += ['numa', 'dl', 'smd']

+    new_env = denv.Clone()
+    new_env.Append(CPPDEFINES=['-DNO_SUCH_ARG'])
+
     tgts = FILES + control_tgts
     bio = denv.d_library("bio", tgts, install_off="../..", LIBS=libs)
     denv.Install('$PREFIX/lib64/daos_srv', bio)
diff --git a/src/bio/bio_bulk.c b/src/bio/bio_bulk.c
index 05d3c5624..bc6bbac80 100644
--- a/src/bio/bio_bulk.c
+++ b/src/bio/bio_bulk.c
@@ -6,6 +6,8 @@
 #define D_LOGFAC       DD_FAC(bio)
 #include "bio_internal.h"

+#error cannot compile.
+
 static int (bulk_create_fn)(void ctxt, d_sg_list_t *sgl, unsigned int perm,
                             void **bulk_hdl);
 static int (bulk_free_fn)(void bulk_hdl);
________________________________
From: Scons-users <scons-users-bounces at scons.org> on behalf of Rob Boehne via Scons-users <scons-users at scons.org>
Sent: Monday, March 6, 2023 12:13 PM
To: SCons users mailing list <scons-users at scons.org>
Cc: Rob Boehne <robb at datalogics.com>
Subject: Re: [Scons-users] SCons 4.5.0 Released


We have also had some things suddenly stop building with 4.5.0 – but it was specific to certain projects.  Here is a traceback on what didn’t build with the new release (and was fixed by pinning SCons to 4.4.0):





09:19:58 TypeError: sequence index must be integer, not 'slice':

09:19:58   File "/devlocal/devauto/Jenkins/workspace/Nightly_Builds/APDFL15/64-Bit/apdfl-sandbox/DLE/SConstruct", line 1001:

09:19:58     add_conan_dependencies(env)

09:19:58   File "/devlocal/devauto/Jenkins/workspace/Nightly_Builds/APDFL15/64-Bit/apdfl-sandbox/DLE/SConstruct", line 277:

09:19:58     env.MergeFlags(values)

09:19:58   File "/devlocal/devauto/Jenkins/workspace/Nightly_Builds/APDFL15/64-Bit/apdfl-sandbox/python-env-rhws6/lib/python3.9/site-packages/SCons/Environment.py", line 1095:

09:19:58     for v in orig[::-1]:

09:19:58 gmake: *** [dle_build] Error 2

09:19:59 Build step 'Conditional step (single)' marked build as failure





From: Scons-users <scons-users-bounces at scons.org> on behalf of Mats Wichmann <mats at wichmann.us>
Date: Monday, March 6, 2023 at 1:01 PM
To: scons-users at scons.org <scons-users at scons.org>
Subject: Re: [Scons-users] SCons 4.5.0 Released

On 3/6/23 11:10, Olivier, Jeffrey V wrote:
> Our project build has broken badly with update to 4.5 and I'm not sure
> why it's happening (See github.com/daos-stack/daos.git).
>
> We make use of Clone() to make modifications to the default environment
> for building various libraries and binaries in our system.   With 4.5,
> we are seeing a leak of CPPDEFINES from some environments to others
> whereas this did not happen prior to 4.5.   I see there were some
> changes in this area.  Any idea what might be causing this.

No, but...

the easier it is to reproduce the easier it is to track down, of course.
  Your project is big and has dependencies so not sure we we can
reproduce from that...



_______________________________________________
Scons-users mailing list
Scons-users at scons.org
https://pairlist4.pair.net/mailman/listinfo/scons-users
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pairlist4.pair.net/pipermail/scons-users/attachments/20230306/ebd3c0bd/attachment-0001.htm>