[Scons-users] Bug report intelc tempfile

[Oscar Anson]

One last related question. Does the env.RES() builder also support these
long command lines?

El vie., 29 nov. 2019 19:51, Bill Deegan <bill at baddogconsulting.com>
escribió:

> Pull requests welcome..
>
> On Fri, Nov 29, 2019 at 9:20 AM Mats Wichmann <mats at wichmann.us> wrote:
>
>> On 11/29/19 9:45 AM, Mats Wichmann wrote:
>> > On 11/29/19 9:40 AM, Oscar Anson wrote:
>> >> We also hit the same issue when upgrading from scons 3.0.0 to 3.1.1
>> >>
>> >> We are using also the Intel compiler and I had to set a space char as
>> >> the join value.
>> >
>> > Hmmm, so maybe it's falling over to a newline too easily. As I recall
>> > the comments at the time, it was supposed to still default to space but
>> > be able to switch if the lines were going to be too long. Perhaps I'm
>> > not remembering right.  Or maybe if the intelc case calls the msvc base
>> > code it ought to override the setting?
>>
>> I think this is just logically inconsistent - the code that uses this
>> does:
>>
>>
>>      fd, tmp = tempfile.mkstemp(suffix, text=True)
>> ...
>>      join_char = env.get('TEMPFILEARGJOIN',' ')
>>      os.write(fd, bytearray(join_char.join(args) + "\n",'utf-8'))
>>      os.close(fd)
>>
>>
>> so it's getting a file from mkstemp explicitly saying open it in text
>> mode, then forcing the thing it's going to write out to bytes... that
>> just doesn't sound right.
>>
>> _______________________________________________
>> Scons-users mailing list
>> Scons-users at scons.org
>> https://pairlist4.pair.net/mailman/listinfo/scons-users
>>
> _______________________________________________
> Scons-users mailing list
> Scons-users at scons.org
> https://pairlist4.pair.net/mailman/listinfo/scons-users
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pairlist4.pair.net/pipermail/scons-users/attachments/20191130/266c0c8f/attachment.html>