[Scons-users] env.MergeFlags does not accept dict CPPDEFINES

[Bill Deegan]

And of course.. if the spirit moves you, a pull request with updated test..

Thanks!
-Bill


On Thu, Jul 13, 2017 at 12:58 PM, Dirk Bächle <tshortik at gmx.de> wrote:

> Olivier,
>
>
> On 13.07.2017 18:18, Olivier Renaud wrote:
>
>> Thanks for the quick reply.
>>
>> I'm afraid I did not search the bugtracker before sending my mail, sorry
>> about that.
>>
>>
> don't worry, thanks for verifying that it's indeed the same issue. Would
> you be able to add your "syntax examples" to one of the main issues? Then
> we could probably use them as starting point when defining proper tests and
> the intended behaviour in detail for each of the possible combinations.
>
> Indeed, the issues you linked to are all various symptoms of the same
>> underlying issue, and my report does not bring anything new. I'm working
>> around the issue by merging the offending CPPDEFINES with custom code, and
>> then merging the rest of the flags with MergeFlags.
>>
>> Though, this unexpected behavior took me a few hours to track down (it
>> did not result in an exception, but in a duplication of the /D flags in the
>> compiler command), and it seems to be easy to run into. May I suggest the
>> MergeFlags method perform a few basic type checks on its input, and at
>> least report any unsupported operation as a warning?
>>
>
> That's a good idea. Again, it would help the project a lot if you could
> find the time and add a corresponding note with this request directly to
> the issue in the Tigris bug tracker. Thanks a lot in advance for that.
>
> Best regards,
>
> Dirk
>
>
> _______________________________________________
> Scons-users mailing list
> Scons-users at scons.org
> https://pairlist4.pair.net/mailman/listinfo/scons-users
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pairlist4.pair.net/pipermail/scons-users/attachments/20170713/9de9e95b/attachment.html>