[Scons-users] Detecting changed targets
Mark Terrel
mark at unbounded.systems
Thu Jan 12 12:18:41 EST 2017
Great, thanks William. All regression tests pass with two important
caveats:
1. There are several tools I don't have installed, so there are tests
with no result. (BTW, is there a docker image that has all the tools
installed so I can do a full run?)
2. This change exposed a bug with interactive mode not correctly
clearing out some cached build info between builds, so my testing also
included this fix
<https://bitbucket.org/scons/scons/pull-requests/386> that's
awaiting feedback/approval.
But I suspect the key difference why you had more trouble with tests is
because I'm not changing the default behavior and it looks like your change
did.
I did start a test run with the default changed and did get some failures.
In the ideal case, we'd probably run all tests with ValidateTarget('none')
and again with ValidateTarget('content'). I suspect you might ask me to do
that now. :)
Is there anything major you'd like to see changed/added before I submit a
pull request? We can work through any of the more minor stuff there.
Mark
P.S. Thanks for the tip on using "-j" with regression tests! That just
made my life better.
Date: Wed, 11 Jan 2017 22:52:56 -0500
From: William Blevins <wblevins001 at gmail.com>
To: SCons users mailing list <scons-users at scons.org>
Subject: Re: [Scons-users] Detecting changed targets
Message-ID:
<CALJHx11x2cgNm5uLyviSdA598Gp0o6kYjHRAZWkJHutPakFTiw at mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Mark,
I am on board with a change like this. It has been proposed or discussed
several times. I dabbled with it a while back to see if it was feasible:
https://bitbucket.org/scons/scons/pull-requests/240/added-
support-for-detecting-corruption/diff
Problem was that this broke tons of tests and I didn't get much in the way
of enthusiasm at the time. How our the tests under your patch? You can run
them like "./runtests.py -a -j <cpus>" from the repo.
V/R,
William
--
Mark Terrel | *Unbounded Systems*
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pairlist4.pair.net/pipermail/scons-users/attachments/20170112/7d2fb41c/attachment.html>
More information about the Scons-users
mailing list