[Scons-users] Possible bug with Value objects

[Tom Tanner (BLOOMBERG/ LONDON)]

One small worry: Shouldn't the __eq__ check the 'other' is another python node. Or you might get situations where someone had set a Value to the same as a filename (ok, they probably deserve what they get but still), which would then get a spurious match.

Otherwise, it all looks good. I'll raise 2 tickets on tigris because I still think it should still tell you if the command line changed. (Actually, 3, because I realised I want to know what the contents changes are, but that's a completely separate issue).

Cheers

Tom

From: dl9obn at darc.de At: Feb 28 2015 10:42:35
To: scons-users at scons.org
Subject: Re: [Scons-users] Possible bug with Value objects

Hi Tom,

On 27.02.2015 17:48, Tom Tanner (BLOOMBERG/ LONDON) wrote:
> I've been trying to get my head round this, but it appears that the code to 
explain why a build has happened has problems with Value
> objects.
>

after some debugging of your example, I share your concerns. There are two 
basic problems, appearing for strange reasons that I 
still didn't fully understand:

1.) The default "__eq__" for Values doesn't work, so "x in l" fails...even if x 
is a member of the seq l, but of type Value!
2.) In the list of children (old_bkids/new_bkids, in Node.explain()), instances 
of the NodeInfo class may exist when Value nodes are 
involved.

Attached you can find a preliminary patch that seems to fix the problem. Do you 
think this is the right way to go, meaning: does 
this look reasonable to you?

Please open a ticket for this issue in the Tigris bug tracker, thanks a lot in 
advance.

Best regards,

Dirk


----------------------------

_______________________________________________
Scons-users mailing list
Scons-users at scons.org
https://pairlist4.pair.net/mailman/listinfo/scons-users


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pairlist4.pair.net/pipermail/scons-users/attachments/20150302/9707db18/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sig_value.txt
Type: application/octet-stream
Size: 2905 bytes
Desc: not available
URL: <https://pairlist4.pair.net/pipermail/scons-users/attachments/20150302/9707db18/attachment.obj>