[Scons-users] Generating visual studio 2012 project files

[William Deegan]

On 01/25/2013 12:29 AM, Dan Pidcock wrote:

>

>

> On 24 Jan 2013 23:01, "Bill Deegan" <bill at baddogconsulting.com 

> <mailto:bill at baddogconsulting.com>> wrote:

> >

> > Dan,

> >

> > On Thu, Jan 24, 2013 at 1:45 PM, Dan Pidcock 

> <dan.pidcock at googlemail.com <mailto:dan.pidcock at googlemail.com>> wrote:

> >>

> >> When I run Scons with compiler=vc11, visual studio 2012 will open them

> >> but complains that they are visual studio 2010 projects and should be

> >> upgraded.

> >>

> >> A diff on the upgraded project file showed they had added

> >> <PlatformToolset>v110</PlatformToolset> to PropertyGroup Condition, so

> >> I modified msvs.py V10DSPPropertyGroupCondition to add that line.

> >>

> >> That works fine but is it the correct way to do it? I expected scons

> >> to work out of the box on VS 11 (2012) as

> >> 

> https://bitbucket.org/scons/scons/pull-request/19/visual-studio-11-support/

> >> has been created. I did check

> >> http://www.scons.org/wiki/PlatformSpecificNotes#Visual_C.2B-.2B- but

> >> couldn't see anything there.

> >

> >

> > Are you running scons 2.2, or from the mercurial depot?

> > Although pull request 19 may have been merged it may not yet be in a 

> released version of SCons.

> > -Bill

>

> Bill,

>

> The version I'm running includes that pull request, but the request 

> doesn't include the change that I made to msvs.Py. I would submit a 

> ticket with patch attached but want to check first that I haven't 

> missed something.

>



Can you create a pull request rather than attach the patch to the bug.
Also if you have a test to cover the change that will make it much 
easier to pull in.

-Bill
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://four.pairlist.net/pipermail/scons-users/attachments/20130125/613dbf17/attachment.html>