[Scons-users] CPPDEFINES Unexpected Behavior

[Managan, Rob]

Dirk

I totally agree with your concern. On the positive side, the changes I looked at were inside of the code that already has checked that the key is CPPDEFINES so it should not affect Append for other keys.
________________________________
From: scons-users-bounces at scons.org [scons-users-bounces at scons.org] on behalf of Dirk Bächle [tshortik at gmx.de]
Sent: Friday, April 12, 2013 12:19 AM
To: SCons users mailing list
Subject: Re: [Scons-users] CPPDEFINES Unexpected Behavior

On 12.04.2013 01:19, Managan, Rob wrote:
Dirk,

[...]
The append logic is where dicts are converted to lists. The first time CPPDEFINES is set (either as an override at construction or adding it to an existing environment) and  the value is a dict it is not converted.

It is not hard to update the append logic to convert the dict to a list first and leave out the None value.


I'm simply a little bit concered that we would have to change this in the Append logic. It is used for a lot of things/vars (not only CPPDEFINES), and in another situation the "fix" could possibly be bad again...

Just my 2 cents.

Dirk

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://four.pairlist.net/pipermail/scons-users/attachments/20130412/d1cd1e28/attachment.htm>